pengfei added inline comments.
================ Comment at: clang/test/Driver/x86-target-features.c:5 // RUN: %clang -target i386-unknown-linux-gnu -march=i386 -mno-80387 %s -### -o %t.o 2>&1 | FileCheck -check-prefix=NO-X87 %s +// RUN: %clang -target i386-unknown-linux-gnu -march=i386 -mno-fp-ret-in-387 %s -### -o %t.o 2>&1 | FileCheck -check-prefix=NO-X87 %s // X87: "-target-feature" "+x87" ---------------- nickdesaulniers wrote: > If you split this test and the above change to > clang/include/clang/Driver/Options.td into a separate patch on Phab, I'd be > happy to accept that! > > Otherwise someone more familiar with x86 will have to take a look at the > below changes. This is a simple alias. Spliting it doesn't solve the initial problem. I think it's better to commit it together with the backend change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112143/new/ https://reviews.llvm.org/D112143 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
