jcking1034 added inline comments.

================
Comment at: clang/docs/tools/dump_ast_matchers.py:13
 
+CLASS_INDEX_PAGE = 
urlopen("https://clang.llvm.org/doxygen/classes.html";).read()
+
----------------
aaron.ballman wrote:
> Do we need to handle an exception here if there are network issues?
Technically, if there is a network issue, any exceptions would cause the script 
to terminate. But I think you're right that we should handle this case more 
carefully.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111332/new/

https://reviews.llvm.org/D111332

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to