gandhi21299 marked an inline comment as done.
gandhi21299 added inline comments.
================
Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:585
+ TLI->shouldExpandAtomicRMWInIR(AI, ORE);
+ OptimizationRemark Remark(DEBUG_TYPE, "Passed", AI->getFunction());
+ switch (Kind) {
----------------
gandhi21299 wrote:
> rampitec wrote:
> > What should this "Passed" do and why wouldn't just declare it where you use
> > it?
> https://llvm.org/docs/Remarks.html
>
> Since this is an informative pass and not that pass failed to optimize, the
> "Passed" argument is used. I will move it downwards, I thought it might be
> useful in the future for other operations. Its better below for now anyways.
Actually I am getting a runtime error at the line where I declare Remark when I
bring it down.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106891/new/
https://reviews.llvm.org/D106891
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
