rampitec added inline comments.
================
Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:618
expandAtomicRMWToCmpXchg(AI, createCmpXchgInstFun);
+ Ctx.getSyncScopeNames(SSNs);
+ auto MemScope = SSNs[AI->getSyncScopeID()].empty()
----------------
Only if SSNs.empty().
================
Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:624
+ Remark << "A compare and swap loop was generated for an "
+ << AI->getOpcodeName() << "operation at " << MemScope
+ << " memory scope";
----------------
I believe getOpcodeName() will return "atomicrmw" instead of the operation.
Also missing space after it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106891/new/
https://reviews.llvm.org/D106891
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
