hubert.reinterpretcast added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:271 // Handle reserved library options. - if (A.getOption().matches(options::OPT_Z_reserved_lib_stdcxx)) + else if (A.getOption().matches(options::OPT_Z_reserved_lib_stdcxx)) TC.AddCXXStdlibLibArgs(Args, CmdArgs); ---------------- Can we move the `OPT_b` block above into the if-else chain after the `OPT_z` case? The `else` occurring after the comment strikes me as being very unfortunate code formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107786/new/ https://reviews.llvm.org/D107786 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits