[PATCH] D107786: [AIX]: Fix option processing for -b

[Ettore Tiotto via Phabricator via cfe-commits]

etiotto created this revision.
etiotto added reviewers: ZarkoCA, hubert.reinterpretcast, Whitney, 
cebowleratibm.
etiotto added a project: LLVM.
etiotto requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Code added by D106688 <https://reviews.llvm.org/D106688> is incorrect. It pass 
the option `-bxyz` to the system linker as `-b xyz xyz` (duplication of the 
string 'xyz' is incorrect).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D107786

Files:
  clang/lib/Driver/ToolChains/CommonArgs.cpp


Index: clang/lib/Driver/ToolChains/CommonArgs.cpp
===================================================================
--- clang/lib/Driver/ToolChains/CommonArgs.cpp
+++ clang/lib/Driver/ToolChains/CommonArgs.cpp
@@ -268,7 +268,7 @@
       A.render(Args, CmdArgs);
     }
     // Handle reserved library options.
-    if (A.getOption().matches(options::OPT_Z_reserved_lib_stdcxx))
+    else if (A.getOption().matches(options::OPT_Z_reserved_lib_stdcxx))
       TC.AddCXXStdlibLibArgs(Args, CmdArgs);
     else if (A.getOption().matches(options::OPT_Z_reserved_lib_cckext))
       TC.AddCCKextLibArgs(Args, CmdArgs);



Index: clang/lib/Driver/ToolChains/CommonArgs.cpp
===================================================================
--- clang/lib/Driver/ToolChains/CommonArgs.cpp
+++ clang/lib/Driver/ToolChains/CommonArgs.cpp
@@ -268,7 +268,7 @@
       A.render(Args, CmdArgs);
     }
     // Handle reserved library options.
-    if (A.getOption().matches(options::OPT_Z_reserved_lib_stdcxx))
+    else if (A.getOption().matches(options::OPT_Z_reserved_lib_stdcxx))
       TC.AddCXXStdlibLibArgs(Args, CmdArgs);
     else if (A.getOption().matches(options::OPT_Z_reserved_lib_cckext))
       TC.AddCCKextLibArgs(Args, CmdArgs);

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits