aaron.ballman added a comment.

In D106431#2912589 <https://reviews.llvm.org/D106431#2912589>, @Sockke wrote:

> Thank you for your reply! I generally understand what you mean, but there are 
> three cases, namely, no diagnosis, providing diagnosis, and providing 
> diagnosis & FixIt.  Only by judging whether "diagnosis" is null may fail to 
> achieve the goal.  I have revised it a little bit, do you think that's 
> alright? @aaron.ballman

By how the code looks, you made the exact changes I was hoping to see. Thank 
you!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106431/new/

https://reviews.llvm.org/D106431

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to