whisperity added a comment.

If we are tinkering with the code post-acceptance, could you please also change 
`const char *` to `StringRef`? They are the same thing essentially, but 
accessing the length is (AFIAK) //O(1)// and there isn't a //concerning// 
`strlen` call in the code.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106431/new/

https://reviews.llvm.org/D106431

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to