airlied added a comment. In D106778#2904509 <https://reviews.llvm.org/D106778#2904509>, @Anastasia wrote:
> Generally LGTM, but I think we should guard the `else` blocks with > CL_VERSION_2_0 or higher to avoid exposing the functions in earlier standards > because the spec says: > > The C11 style atomic functions in this sub-section require support for > OpenCL 2.0 or newer. However, this statement does not apply to the "OpenCL C > 1.x Legacy Atomics" descriptions at the end of this sub-section. > > Adding @azabaznov to check if he can suggest anything for testing. Although > it seems like this is only related to the new functionality of OpenCL3.0. The whole atomic section is wrapped in #if defined(__OPENCL_CPP_VERSION__) || (__OPENCL_C_VERSION__ >= CL_VERSION_2_0) is that not good enough coverage? I'll add the endif fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106778/new/ https://reviews.llvm.org/D106778 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
