arichardson added inline comments.
================ Comment at: llvm/include/llvm/Support/TargetParser.h:177 StringRef resolveTuneCPUAlias(StringRef TuneCPU, bool IsRV64); +StringRef computeABIByArch(bool HasD, bool HasE, bool IsRV64); ---------------- Maybe this should be `computeDefaultABIFromArch()`? If `llvm::RISCVISAInfo` can be used here passing `const llvm::RISCVISAInfo&` to the function would also avoid some duplicated lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105555/new/ https://reviews.llvm.org/D105555 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
