dexonsmith added a comment. Could the DarwinSDKInfo changes be tested directly with C++ unit tests? Since this stuff is in Basic it'd be nice to test it separately from the driver. If so, maybe they could also mostly land in a separate prep commit (except the update to `clang::parseDarwinSDKInfo` which is what changes the Driver behaviour).
================ Comment at: clang/include/clang/Basic/DarwinSDKInfo.h:129 + static Optional<DarwinSDKInfo> + parseDarwinSDKSettingsJSON(StringRef FilePath, const llvm::json::Object *Obj); + ---------------- Should this take the VFS? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105257/new/ https://reviews.llvm.org/D105257 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
