grokos added inline comments.
================ Comment at: clang/docs/ClangOffloadBundler.rst:128 + + <Architecture>-<Vendor>-<OS>-<Environment> + ---------------- A bit of wordplay, but it's weird that a *triple* now has 4 elements... ================ Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:147 + Target.split(Components, '-', 5); + Components.resize(6); + this->OffloadKind = Components[0]; ---------------- Leftover? `Components` is already 6 elements long. ================ Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:1102 +/// compatible with this code object +/// @param [in] Code Object \p CodeObject +/// @param [out] List of all compatible targets \p CompatibleTargets among all ---------------- `CodeObject` --> `CodeObjectInfo` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93525/new/ https://reviews.llvm.org/D93525 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
