efriedma added inline comments.

================
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2103
+      if (const CallExpr *CE = dyn_cast<CallExpr>(E))
+        Ty = CE->getCallReturnType(CGF.getContext());
+
----------------
I don't think we need to call getCallReturnType() here.  A call that returns a 
reference is an lvalue, and the code here expects an rvalue.  So 
CE->getCallReturnType() is going to be the same as E->getType().


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105097/new/

https://reviews.llvm.org/D105097

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to