steveire added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.cpp:87
const auto IntegerExpr = ignoringParenImpCasts(integerLiteral());
- const auto ConstantExpr = expr(ignoringParenImpCasts(
+ const auto ConstantExpr = ignoringParenImpCasts(
anyOf(integerLiteral(), unaryOperator(hasUnaryOperand(IntegerExpr)),
----------------
A lot of this MR is removal of redundant `expr()` and `qualType()`, but mixed
in with the diff is changes like those to `SizeOfExpr` below. This MR would be
much easier to review if you broke out the removal of redundant matchers to its
own MR (or just commit it as an NFC). That would leave behind the more-complex
changes like things like `SizeOfExpr`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101614/new/
https://reviews.llvm.org/D101614
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
