abhina.sreeskantharajan marked 2 inline comments as done. abhina.sreeskantharajan added inline comments.
================ Comment at: llvm/utils/lit/lit/llvm/config.py:349-351 + triple = "" + if hasattr(self.config, 'host_triple'): + triple = self.config.host_triple ---------------- jhenderson wrote: > I'm concerned that someone might start using these substitutions in a project > for the first time, and get confused why they don't work on non-windows > platforms. Maybe the solution is simply to require LLVM_HOST_TRIPLE to be set > in all projects, i.e. go back to what you were doing before, and letting > python fail if it isn't set. > > Happy to hear other ideas too. I think using sys.platform or platform.system() could be a better alternative. What do you think? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95246/new/ https://reviews.llvm.org/D95246 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
