shafik added inline comments.
================ Comment at: clang/include/clang/AST/APValue.h:405 assert(isInt() && "Invalid accessor"); - return *(APSInt*)(char*)Data.buffer; + return *(APSInt *)(char *)&Data; } ---------------- I notice that in `ASTTypeTraits.h` we use `reinterpret_cast` while here we revert to C-style casts. ================ Comment at: clang/include/clang/AST/APValue.h:511 assert(isArray() && "Invalid accessor"); - return ((const Arr*)(const void *)Data.buffer)->NumElts; + return ((const Arr *)(const void *)&Data)->NumElts; } ---------------- What is it `char *` in some cases and `void*` in others? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92512/new/ https://reviews.llvm.org/D92512 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits