rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Looks good to me.
================
Comment at: llvm/include/llvm/Support/ErrorOr.h:256-257
union {
AlignedCharArrayUnion<storage_type> TStorage;
AlignedCharArrayUnion<std::error_code> ErrorStorage;
};
----------------
This union of unions of one type seems silly. I think there can be as single
`Storage` field. Anyway, fixing this is not in scope for this patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92512/new/
https://reviews.llvm.org/D92512
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
