zequanwu added a comment.

In D91747#2423960 <https://reviews.llvm.org/D91747#2423960>, @rnk wrote:

> If we believe the standard says that the compiler is supposed to set 
> `__STDCPP_THREADS__`, then I think the libc++ #error needs to be adjusted. 
> libcxxabi, or any other client, should be able to define 
> `_LIBCPP_HAS_NO_THREADS`, and it should work, even if the compiler thinks 
> they are allowed.

So, we could remove the checking for if `__STDCPP_THREADS__` and 
`_LIBCPP_HAS_NO_THREADS` are both set. And let libcxx adds flag `-mthread-model 
single` to use single thread (but this is compiler specific flag, might need a 
better solution).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91747/new/

https://reviews.llvm.org/D91747

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to