zequanwu marked an inline comment as done. zequanwu added inline comments.
================ Comment at: clang/test/CXX/cpp/cpp.predefined/p2.cpp:1 +// RUN: %clang_cc1 %s -verify +// expected-no-diagnostics ---------------- rnk wrote: > Let's expand on this: > - test that we don't set the macro when compiling C (`-x c`) > - test that we don't set the macro when `-mthread-model single` is passed > > Pass an extra macro def on the command line to control the preprocessor test > expectations similar to p1.cpp I found split-file is handy to separate different test expectations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91747/new/ https://reviews.llvm.org/D91747 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
