njames93 added inline comments.
================ Comment at: clang-tools-extra/clangd/Selection.cpp:40 +std::string getLanguage(const clang::LangOptions &Lang) { + if (Lang.C99 || Lang.C11 || Lang.C17 || Lang.C2x) ---------------- Nit: any reason to use std::string here instead StringRef. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92157/new/ https://reviews.llvm.org/D92157 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits