kadircet added inline comments.
================ Comment at: clang-tools-extra/clangd/Selection.cpp:51 // Measure the fraction of selections that were enabled by recovery AST. -void recordMetrics(const SelectionTree &S) { +void recordMetrics(const SelectionTree &S, const ASTContext &AST) { static constexpr trace::Metric SelectionUsedRecovery( ---------------- nit: it might be nice to bail out early if no tracer is attached with `trace::enabled` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92157/new/ https://reviews.llvm.org/D92157 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits