rsmith added a comment. Thanks! We should also have a test for the behavior when targeting the MS ABI, where we sometimes don't emit the `nonnull dereferenceable` because the "`this`" pointer might actually point outside the object, but otherwise I think this is ready to go.
Please can you also put together a patch for the release notes? This seems worth mentioning there. ================ Comment at: clang/test/CodeGenCXX/this-nonnull.cpp:1-2 +// RUN: %clang -S -emit-llvm -o - -fdelete-null-pointer-checks %s | FileCheck %s -check-prefix=CHECK-YES +// RUN: %clang -S -emit-llvm -o - -fno-delete-null-pointer-checks %s | FileCheck %s -check-prefix=CHECK-NO + ---------------- This test needs a `-triple` or it will fail on (at least) non-Itanium hosts. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17993/new/ https://reviews.llvm.org/D17993 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
