rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/test/CodeGenCXX/this-nonnull.cpp:1-2 +// RUN: %clang_cc1 -S -emit-llvm -o - -triple %itanium_abi_triple %s | FileCheck %s -check-prefix=CHECK-YES +// RUN: %clang_cc1 -S -emit-llvm -o - -fno-delete-null-pointer-checks -triple %itanium_abi_triple %s | FileCheck %s -check-prefix=CHECK-NO + ---------------- Please use a specific triple here (eg `x86_64-linux-gnu`); right now this test would fail on Itanium targets where `sizeof(Struct)` is not exactly 12 (which is not guaranteed -- `int` might not be 32 bits wide on all Itanium targets). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17993/new/ https://reviews.llvm.org/D17993 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
