hokein added a comment. In D85417#2201953 <https://reviews.llvm.org/D85417#2201953>, @ArcsinX wrote:
> In D85417#2199830 <https://reviews.llvm.org/D85417#2199830>, @ArcsinX wrote: > >> In D85417#2199694 <https://reviews.llvm.org/D85417#2199694>, @hokein wrote: >> >>> Looks like NotNullTerminatedResultCheck.cpp also has this pattern, we may >>> want to fix that as well. >> >> Yes, you are right. I will fix this in the next patch. > > @hokein Sorry for bother you. Seems `bugprone-not-null-terminated-result` has > the same 3 problems as `bugprone-bad-signal-to-kill-thread`: > > - `#undef __STDC_WANT_LIB_EXT1__` > - `#define __STDC_WANT_LIB_EXT1__ ((unsigned)1)` > - `Token::PtrData == nullptr` inside clangd > > Do you expect separate 3 patches for this (as we did for > `bugprone-bad-signal-to-kill-thread`) ? yeah, that would be nice. Thanks for digging into this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85417/new/ https://reviews.llvm.org/D85417 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
