This revision was automatically updated to reflect the committed changes.
Closed by commit rGb907ad539a90: [NFC] Clean up doc comment and implementation
for Module::isSubModuleOf. (authored by aprantl).
Changed prior to commit:
https://reviews.llvm.org/D84087?vs=278972&id=279659#toc
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84087/new/
https://reviews.llvm.org/D84087
Files:
clang/include/clang/Basic/Module.h
clang/lib/Basic/Module.cpp
Index: clang/lib/Basic/Module.cpp
===================================================================
--- clang/lib/Basic/Module.cpp
+++ clang/lib/Basic/Module.cpp
@@ -173,14 +173,10 @@
}
bool Module::isSubModuleOf(const Module *Other) const {
- const Module *This = this;
- do {
- if (This == Other)
+ for (auto *Parent = this; Parent; Parent = Parent->Parent) {
+ if (Parent == Other)
return true;
-
- This = This->Parent;
- } while (This);
-
+ }
return false;
}
Index: clang/include/clang/Basic/Module.h
===================================================================
--- clang/include/clang/Basic/Module.h
+++ clang/include/clang/Basic/Module.h
@@ -457,8 +457,12 @@
/// Determine whether this module is a submodule.
bool isSubModule() const { return Parent != nullptr; }
- /// Determine whether this module is a submodule of the given other
- /// module.
+ /// Check if this module is a (possibly transitive) submodule of \p Other.
+ ///
+ /// The 'A is a submodule of B' relation is a partial order based on the
+ /// the parent-child relationship between individual modules.
+ ///
+ /// Returns \c false if \p Other is \c nullptr.
bool isSubModuleOf(const Module *Other) const;
/// Determine whether this module is a part of a framework,
Index: clang/lib/Basic/Module.cpp
===================================================================
--- clang/lib/Basic/Module.cpp
+++ clang/lib/Basic/Module.cpp
@@ -173,14 +173,10 @@
}
bool Module::isSubModuleOf(const Module *Other) const {
- const Module *This = this;
- do {
- if (This == Other)
+ for (auto *Parent = this; Parent; Parent = Parent->Parent) {
+ if (Parent == Other)
return true;
-
- This = This->Parent;
- } while (This);
-
+ }
return false;
}
Index: clang/include/clang/Basic/Module.h
===================================================================
--- clang/include/clang/Basic/Module.h
+++ clang/include/clang/Basic/Module.h
@@ -457,8 +457,12 @@
/// Determine whether this module is a submodule.
bool isSubModule() const { return Parent != nullptr; }
- /// Determine whether this module is a submodule of the given other
- /// module.
+ /// Check if this module is a (possibly transitive) submodule of \p Other.
+ ///
+ /// The 'A is a submodule of B' relation is a partial order based on the
+ /// the parent-child relationship between individual modules.
+ ///
+ /// Returns \c false if \p Other is \c nullptr.
bool isSubModuleOf(const Module *Other) const;
/// Determine whether this module is a part of a framework,
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
