aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang/lib/Basic/Module.cpp:176
bool Module::isSubModuleOf(const Module *Other) const {
- const Module *This = this;
- do {
+ for (const Module *This = this; This != nullptr; This = This->Parent) {
if (This == Other)
----------------
```
for (const Module *Parent = this; Parent; Parent = Parent->Parent) {
if (Parent == Other)
return true;
}
```
?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84087/new/
https://reviews.llvm.org/D84087
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
