aaron.ballman added inline comments.
================
Comment at: clang/include/clang/Basic/Attr.td:1541
+def ArmSveVectorBits128 : TypeAttr {
+ let Spellings = [];
----------------
sdesmalen wrote:
> nit: Can you add a comment saying why these are undocumented (and have no
> spellings)
Also, I think these are all missing `let SemaHandler = 0;` and `let ASTNode =
0;`
Is there a reason why we need N different type attributes instead of having a
single type attribute which encodes the N as an argument? I think this may
simplify the patch somewhat as you no longer need to switch over N as much.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83551/new/
https://reviews.llvm.org/D83551
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
