JohelEGP added a comment. Yes, it's valid C++ (is my hope). It's from WIP code, which I made available to show you: https://github.com/johelegp/jge.
Here it is building, running and passing the tests: https://travis-ci.com/github/johelegp/jge/jobs/358137355#L559. Here are links to the above linked snippets: - Now looking good: - https://github.com/johelegp/jge/blob/master/include/jge/cartesian.hpp#L84-L90 - https://github.com/johelegp/jge/blob/master/include/jge/plane.hpp#L54-L59 - https://github.com/johelegp/jge/blob/master/tests/jge/cartesian.cpp#L18-L20. - Just reported: - Inheritance: https://github.com/johelegp/jge/blob/master/tests/jge/cartesian.cpp#L11-L21 (https://reviews.llvm.org/D79773#2131680) - Non list-initialization: https://github.com/johelegp/jge/blob/master/tests/jge/cartesian.cpp#L11-L16 (https://reviews.llvm.org/D79773#2132086) - For the `EqualityComparable` case (https://reviews.llvm.org/D79773#2131680), I use this macro: https://github.com/johelegp/jge/blob/master/include/jge/detail/quantity_wrappers.hpp#L4-L5. Example: https://github.com/johelegp/jge/blob/master/include/jge/detail/quantity_wrappers.hpp#L59. I also used it before the previous fixes besides `//` comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79773/new/ https://reviews.llvm.org/D79773 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
