curdeius marked an inline comment as done.
curdeius added inline comments.
================
Comment at: clang/unittests/Format/FormatTest.cpp:13540
CHECK_PARSE_BOOL(AlignConsecutiveMacros);
+ CHECK_PARSE_BOOL(AlwaysBreakBeforeConceptDeclarations);
CHECK_PARSE_BOOL(AllowAllArgumentsOnNextLine);
----------------
MyDeveloperDay wrote:
> curdeius wrote:
> > Format: leading whitespace. Should it be in the same "group" as
> > `AlignConsecutiveMacros`?
> I might be misunderstanding your comment, but the list should alphabetic but
> now I realize it should be after the `Allows`
I just wanted to point out that when you don't put a blank line after
CHECK_PARSE_BOOL, then the next one gets indented. And yes, the order isn't ok.
BTW, us "Always" in the name necessary? Cf. other "Break" options.
================
Comment at: clang/unittests/Format/FormatTest.cpp:16745
+ " ::std::is_copy_constructable<T> and "
+ "::std::is_move_constructable<T> and\n"
+ " requires (T c) {\n"
----------------
MyDeveloperDay wrote:
> curdeius wrote:
> > Isn't it a strange indentation?
> there is no newline on the line above, but I clang-format the tests so it
> wraps it, I know visually its confusing
O, ok, thanks for the explanation. It's indeed confusing in the review.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79773/new/
https://reviews.llvm.org/D79773
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
