balazske marked 2 inline comments as done. balazske added inline comments.
================ Comment at: clang/lib/Analysis/PathDiagnostic.cpp:333 + if (XL.isValid() && YL.isInvalid()) + return false; std::pair<FileID, unsigned> XOffs = XL.getDecomposedLoc(); ---------------- baloghadamsoftware wrote: > Why this asymmetry? The function returns something like "`XL` is less than `YL`". The invalid source locations should come always as first (or last?) in the ordering. ================ Comment at: clang/lib/Analysis/PathDiagnostic.cpp:389 + return *Result; } PathDiagnostic::meta_iterator XI = X.meta_begin(), XE = X.meta_end(); ---------------- baloghadamsoftware wrote: > Asymmetry again. What if YUL is valid? Here we have already a precondition that `XUL == YUL` (from line 358). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83115/new/ https://reviews.llvm.org/D83115 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
