baloghadamsoftware added inline comments.
================ Comment at: clang/lib/Analysis/PathDiagnostic.cpp:333 + if (XL.isValid() && YL.isInvalid()) + return false; std::pair<FileID, unsigned> XOffs = XL.getDecomposedLoc(); ---------------- Why this asymmetry? ================ Comment at: clang/lib/Analysis/PathDiagnostic.cpp:389 + return *Result; } PathDiagnostic::meta_iterator XI = X.meta_begin(), XE = X.meta_end(); ---------------- Asymmetry again. What if YUL is valid? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83115/new/ https://reviews.llvm.org/D83115 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
