kadircet marked 9 inline comments as done. kadircet added inline comments.
================ Comment at: clang-tools-extra/clangd/ClangdServer.cpp:555 // different code layout. if (auto CorrespondingFile = getCorrespondingHeaderOrSource( + std::string(Path), FSProvider.getFileSystem(llvm::None))) ---------------- sammccall wrote: > we could plumb in threadsafefs here too... this function is also used by tweaks (DefineOutline), and they don't have access to FSProvider. I would rather do that plumbing on a separate patch. ================ Comment at: clang-tools-extra/clangd/Preamble.cpp:424 + auto VFS = Baseline.StatCache->getConsumingFS( + Modified.FSProvider->getFileSystem(Modified.CompileCommand.Directory)); // First scan preprocessor directives in Baseline and Modified. These will be ---------------- sammccall wrote: > I don't see a corresponding removed CD - is this a bugfix? not really, CWD doesn't matter for preamble scanning as we only go over current file contents that are set explicitly. It will actually be dropped by https://reviews.llvm.org/D81719, changing it to pass None here to not confuse. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81920/new/ https://reviews.llvm.org/D81920 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
