uabelho added inline comments.
================
Comment at: clang-tools-extra/clangd/support/FSProvider.h:39
+ virtual llvm::IntrusiveRefCntPtr<llvm::vfs::FileSystem>
+ getFileSystem(PathRef CWD) const;
};
----------------
I noticed that gcc (7.4) warns on this line:
```
/data/repo/master/clang-tools-extra/clangd/support/FSProvider.h:39:3: warning:
'virtual llvm::IntrusiveRefCntPtr<llvm::vfs::FileSystem>
clang::clangd::FileSystemProvider::getFileSystem(clang::clangd::PathRef) const'
was hidden [-Woverloaded-virtual]
getFileSystem(PathRef CWD) const;
^~~~~~~~~~~~~
```
================
Comment at: clang-tools-extra/clangd/support/FSProvider.h:45
llvm::IntrusiveRefCntPtr<llvm::vfs::FileSystem>
- getFileSystem() const override;
+ getFileSystem(llvm::NoneType) const override;
};
----------------
Similar warning here as well:
```
/data/repo/master/clang-tools-extra/clangd/support/FSProvider.h:45:7: warning:
by 'virtual llvm::IntrusiveRefCntPtr<llvm::vfs::FileSystem>
clang::clangd::RealFileSystemProvider::getFileSystem(llvm::NoneType) const'
[-Woverloaded-virtual]
getFileSystem(llvm::NoneType) const override;
^~~~~~~~~~~~~
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81920/new/
https://reviews.llvm.org/D81920
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
