nickdesaulniers marked 3 inline comments as done.
nickdesaulniers added inline comments.
================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5369
if (ES->hasExternalDefinitions(D) == ExternalASTSource::EK_Never)
- DebugInfo->completeUnusedClass(cast<CXXRecordDecl>(*D));
+ DebugInfo->completeUnusedClass(*CRD);
}
----------------
dblaikie wrote:
> nickdesaulniers wrote:
> > The difference between using `DebugInfo` vs `getModuleDebugInfo` in this
> > method is *killing* me. Same with `return` vs `break`.
> Feel free to send separate patches to clean these things up.
https://reviews.llvm.org/D80840
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80242/new/
https://reviews.llvm.org/D80242
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
