nickdesaulniers added inline comments.
================ Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5559 + case Decl::Typedef: + if (getCodeGenOpts().DebugUnusedTypes) + if (CGDebugInfo *DI = getModuleDebugInfo()) ---------------- dblaikie wrote: > Probably test this within the implementation of CGDebugInfo? & rename the > EmitTypedef function to something that clarifies that it's for an otherwise > unused type? > > But that function might need to be generalized further, rather than only > having it for typedefs. (see general comment above) I think it makes sense at this point to rename `EmitExplicitCastType` to `RetainType` or `EmitType`. WDYT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
