efriedma added a comment.

Okay, I think we're mostly on the same page, then.
I have a few issues here:

1. Whether the backend wants this information is really a per-function 
decision, not a per-module decision; using module-level metadata is sort of 
weird.
2. Having weird rules like this makes it harder to write a non-clang frontend 
producing LLVM IR.
3. All metadata produced and used by in-tree code needs to be documented in 
LangRef.
4. Is there some reason this analysis needs to run in the middle of the pass 
pipeline, as opposed to running it closer to where we actually use the 
information?  Along those lines, do we need to encode this as metadata at all?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80046/new/

https://reviews.llvm.org/D80046



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to