eugenis added a comment.

I think this is an OK approach.
Perhaps a module flag would be even better, then it can be decoupled from 
"sanitize_memtag", and it would not require iterating over the entire module. 
You can check how it is used in CFI: !"CFI Canonical Jump Tables".

It could also be better, instead of iterating over all functions, simply run 
the global pass, but make sure that it does not do too much work on 
non-sanitize_memtag functions. I.e. the function pass should bail out on such 
functions, and then the data flow will have no data to run on, so that should 
also be pretty fast.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80046/new/

https://reviews.llvm.org/D80046



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to