ztamas marked 3 inline comments as done. ztamas added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/bugprone/SignedCharMisuseCheck.h:41 const std::string CharTypdefsToIgnoreList; + const bool CertSTR34C; }; ---------------- aaron.ballman wrote: > I'd prefer a more descriptive name than this -- most people reading the code > won't be familiar with that coding standard. How about > `DiagnoseSignedUnsignedCharComparisons` or something along those lines? OK, I updated the code to use this option name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79334/new/ https://reviews.llvm.org/D79334 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits