sdesmalen marked 4 inline comments as done. sdesmalen added inline comments.
================ Comment at: clang/lib/CodeGen/CGBuiltin.cpp:8054 + + Value *Alloca = Builder.CreateAlloca(EltTy, Builder.getInt32(NumOpnds)); + for (unsigned I = 0; I < NumOpnds; ++I) ---------------- efriedma wrote: > Please use something like `CreateTempAlloca(llvm::ArrayType::get(EltTy, > NumOpnds), CharUnits::fromQuantity(16))`. > > (In particular, the way you've written it, the code allocates stack memory > dynamically. Might want to add a test with some control flow to demonstrate > that you're putting the alloca into the entry block.) Good shout, I didn't realise that. I've fixed that in the latest revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78750/new/ https://reviews.llvm.org/D78750 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
