sdesmalen added a comment. In D78750#2009037 <https://reviews.llvm.org/D78750#2009037>, @efriedma wrote:
> Is there some reason you decided to implement these particular functions as > inline functions directly in the header? Earlier implementations of the ACLE had a lot more things done in the header file (such as the predication with zero/undef, immediate checks, etc). We've moved most of that to CGBuiltins. These macros were a bit specific and hadn't been moved to CGBuiltin yet, but are now kind of remnants of the old implementation. These are better expressed like the other builtins, so that we can further simplify the header file and maybe get rid of it entirely at some point. I've updated the patch accordingly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78750/new/ https://reviews.llvm.org/D78750 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
