baloghadamsoftware marked 3 inline comments as done.
baloghadamsoftware added a comment.

In D75514#1917450 <https://reviews.llvm.org/D75514#1917450>, @Szelethus wrote:

> The code from in `ExprInspectionChecker.cpp` is duplicated from D75677 
> <https://reviews.llvm.org/D75677>, isn't it?


It is. The one accepted earlier will be committed earlier, then I will rebase 
the other one so this part disappears from that one.



================
Comment at: clang/test/Analysis/container-modeling.cpp:100-101
 
-  V.emplace_back(n); // expected-note 2{{Container 'V' extended to the right 
by 1 position}}
+  V.emplace_back(n); // expected-note{{Container 'V' extended to the right by 
1 position}}
+                     // expected-note@-1{{Container 'V' extended to the right 
by 1 position}}
 
----------------
Szelethus wrote:
> Why did we unpack this? And the rest?
We did not unpack this but forgot to pack it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75514/new/

https://reviews.llvm.org/D75514



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to