xazax.hun added a comment. In D75842#1912364 <https://reviews.llvm.org/D75842#1912364>, @baloghadamsoftware wrote:
> In D75842#1912293 <https://reviews.llvm.org/D75842#1912293>, @xazax.hun wrote: > > > I am not sure if I would call this a bugfix. Enabling a checker without one > > of its dependency will potentially cause the checker to misbehave. I am > > uncomfortable changing the current behavior to a more dangerous one without > > any diagnostics. Including the diagnostic with this patch should not make > > this too big. > > > This //is// a bugfix. The current behavior is wrong due to a mistake. A > checker is registered which should not and this may cause crashes. Oh, sorry. I misunderstood the description. My bad. In this case I am ok with having the diagnostic in a separate patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75842/new/ https://reviews.llvm.org/D75842 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
