Szelethus added a subscriber: dcoughlin. Szelethus added a comment. In D75842#1912249 <https://reviews.llvm.org/D75842#1912249>, @baloghadamsoftware wrote:
> In D75842#1912246 <https://reviews.llvm.org/D75842#1912246>, @xazax.hun wrote: > > > If we disable the dependency of a checker explicitly I think we should at > > least emit a warning. > > > I agree, but I do not thik that this should be part of this patch. This is > only a small bugfix. Oof. We wanted to do that for a long time but there were compatibility concerns -- in any case, we totally could emit an //error// at least when `-analyzer-config-compatibility-mode` is false and for newer checkers and a warning for older ones. I distinctively remember a lot of concerns being raised around this. @dcoughlin, @NoQ, how does what I suggested here sound like? In D75842#1912250 <https://reviews.llvm.org/D75842#1912250>, @baloghadamsoftware wrote: > I looked in the `unittests` directory but could not find tests for dependency > handling. @Szelethus, feel free to commandeer this patch if you know how to > test it. This should be the thing you're looking for: `clang/unittests/StaticAnalyzer/RegisterCustomCheckersTest.cpp`. It might be a good idea to wait for me to land D67335 <https://reviews.llvm.org/D67335> first, though :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75842/new/ https://reviews.llvm.org/D75842 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
