baloghadamsoftware requested changes to this revision.
baloghadamsoftware added a comment.
This revision now requires changes to proceed.

This patch still does not help. Most of the functions of `CheckerManager` are 
non-const thus they cannot be called on a const object. E.g. 
`getAnalyzerOptions()` is non-const (why?). For error reporting 
`getASTContext()` should be const as well (to access the diagnostics engine). 
Thus either `CheckerManager` should be changed by setting its getters to const 
or the `shouldRegister`//XXX//`()` should take a non-const reference to 
`CheckerManager`. I would prefer the former one.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75271/new/

https://reviews.llvm.org/D75271



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to