martong marked an inline comment as done. martong added a comment. In D75678#1907449 <https://reviews.llvm.org/D75678#1907449>, @NoQ wrote:
> Thanks!! I also recommend a more direct test with `-analyzer-display-progress > | FileCheck`. Ok, I added a new test file with FileCheck. ================ Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:507-508 + // Skip analysis of inherited constructors as top-level functions because we + // cannot model the parameters. + // ---------------- NoQ wrote: > That's probably the last reason why we should skip them :) I think we should > focus on how these constructors don't even have a body written down in the > code, so even if we find a bug, we won't be able to display it. We might as > well find the bug in the inherited constructors (also > /~~inherited~~/inheriting/ in your comment). Ok, I changed the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75678/new/ https://reviews.llvm.org/D75678 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
