ABataev added inline comments.

================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:15684-15685
+  bool VisitUnaryOperator(UnaryOperator *UO) {
+    if (SemaRef.getLangOpts().OpenMP < 50 || UO->getOpcode() != UO_Deref ||
+        !UO->isLValue()) {
+      emitErrorMsg();
----------------
ABataev wrote:
> `UO_Deref` is always r-value. So, `!UO->isLValue()` will be always triggered 
> for `UO_Deref`. You can just exclude it from the condition.
Oops, sorry, wrong comment, thought about Addr_of, but you removed it already.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75077/new/

https://reviews.llvm.org/D75077



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to