Xiangling_L marked 3 inline comments as done.
Xiangling_L added inline comments.
================
Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:520
+
+class XLCXXABI final : public ItaniumCXXABI {
+public:
----------------
sfertile wrote:
> Here would be a good place to add a comment to indicate that XL has several
> C++ ABIs, but this represents the one used in 'xlClang++'.
You mean we have legacy XLC and XLClang++ ABI? But for static init, they have
same implementation. So it's not a must to point it out.
And also AFAIK, `static init` is the only thing we will differ from Generic
Itanium ABI in the frontend, so basically it's the only thing we will add in
this ABI.
I am okay with either way with a little concern that legacy XLC user may wonder
is there any difference of static init implementation between XLC and XLClang++
ABI if we add the comment.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74015/new/
https://reviews.llvm.org/D74015
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
