Xiangling_L marked 4 inline comments as done.
Xiangling_L added inline comments.
================
Comment at: clang/include/clang/Basic/TargetCXXABI.h:116
+ /// - static initialization is adjusted to use sinit and sterm functions;
+ XL_Clang,
+
----------------
daltenty wrote:
> Why the underscore in the name? This is a bit inconsistent with both the LLVM
> naming convention here and the name as it appears in other sources.
There are various AIX ABI. So to distinguish the one we are implementing, we
choose `XL` and `Clang` as two parts of the abi name.
`XL` - not g++;
`Clang` - it's a ABI implemented in Clang;
And also `XLClang` is misleading because it represents our AIX XL C/C++
compiler itself externally.
================
Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:520
+
+class XLClangCXXABI final : public ItaniumCXXABI {
+public:
----------------
stevewan wrote:
> The class name here is inconsistent with how our ABI kind was called
> previously, as David pointed out. Maybe rename the ABI kind `XLClang`?
I understand you concerns, and please see my replies above.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74015/new/
https://reviews.llvm.org/D74015
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
