gribozavr2 marked an inline comment as done.
gribozavr2 added inline comments.
================
Comment at: clang/test/Sema/warn-documentation-fixits.c:27
+
+// CHECK: fix-it:"{{.*}}":{7:1-7:1}:"[[ATTRIBUTE]] "
+// CHECK: fix-it:"{{.*}}":{11:1-11:1}:"[[ATTRIBUTE]] "
----------------
Mordante wrote:
> gribozavr2 wrote:
> > "[[ATTRIBUTE]]"?
> >
> > I expected either "[[deprecated]]" or "ATTRIBUTE".
> >
> > Oh, these are FileCheck's regex brackets, which make it just a literal
> > "ATTRIBUTE"... I think it would be clearer without the brackets :)
> These are not simple regex bracket, but they are substitution blocks [1].
> These are defined by the RUN scrips to select between the
> `__attribute__((deprecated)) ` and `[[deprecated]]` replacements.
>
> [1]
> https://llvm.org/docs/CommandGuide/FileCheck.html#filecheck-string-substitution-blocks
Oh, it is FileCheck's -D flag... sorry I misread it. Please carry on.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71141/new/
https://reviews.llvm.org/D71141
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
