gribozavr2 accepted this revision.
gribozavr2 added a comment.
LGTM with comments fixed.
================
Comment at: clang/lib/AST/CommentSema.cpp:698
+ // - In C2x/C++14 we prefer [[deprecated]]
+ // - If not found or an older C/C++ look for __attribute__((deprecated))
+ StringRef MacroName;
----------------
I know I'm nit-picking, but I'd appreciate periods at the end of sentences.
================
Comment at: clang/test/Sema/warn-documentation-fixits.c:27
+
+// CHECK: fix-it:"{{.*}}":{7:1-7:1}:"[[ATTRIBUTE]] "
+// CHECK: fix-it:"{{.*}}":{11:1-11:1}:"[[ATTRIBUTE]] "
----------------
"[[ATTRIBUTE]]"?
I expected either "[[deprecated]]" or "ATTRIBUTE".
Oh, these are FileCheck's regex brackets, which make it just a literal
"ATTRIBUTE"... I think it would be clearer without the brackets :)
================
Comment at: clang/test/Sema/warn-documentation-fixits.cpp:130
// CHECK: fix-it:"{{.*}}":{19:13-19:18}:"SomeTy"
-// CHECK: fix-it:"{{.*}}":{26:1-26:1}:"__attribute__((deprecated)) "
-// CHECK: fix-it:"{{.*}}":{30:1-30:1}:"__attribute__((deprecated)) "
-// CHECK: fix-it:"{{.*}}":{35:3-35:3}:"__attribute__((deprecated)) "
-// CHECK: fix-it:"{{.*}}":{39:3-39:3}:"__attribute__((deprecated)) "
-// CHECK: fix-it:"{{.*}}":{47:3-47:3}:"__attribute__((deprecated)) "
-// CHECK: fix-it:"{{.*}}":{51:3-51:3}:"__attribute__((deprecated)) "
-// CHECK: fix-it:"{{.*}}":{76:3-76:3}:"__attribute__((deprecated)) "
-// CHECK: fix-it:"{{.*}}":{81:3-81:3}:"__attribute__((deprecated)) "
-// CHECK14: fix-it:"{{.*}}":{87:3-87:3}:"__attribute__((deprecated)) "
+// CHECK: fix-it:"{{.*}}":{26:1-26:1}:"[[ATTRIBUTE]] "
+// CHECK: fix-it:"{{.*}}":{30:1-30:1}:"[[ATTRIBUTE]] "
----------------
s/[[ATTRIBUTE]]/ATTRIBUTE/ here as well.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71141/new/
https://reviews.llvm.org/D71141
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
